Refactor firstchar function for conciseness and modern syntax #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ayoub-Mabrouk
commented
Oct 31, 2024
Ayoub-Mabrouk
commented
- Replaced var with const for improved variable management
- Used optional chaining for a more concise return statement
- Enhanced readability while preserving functionality
- Replaced var with const for improved variable management - Used optional chaining for a more concise return statement - Enhanced readability while preserving functionality
UlisesGascon
approved these changes
Oct 31, 2024
bjohansebas
approved these changes
Nov 2, 2024
wesleytodd
requested changes
Nov 14, 2024
Member
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
I see approvals on this. We have never accepted style changes before, and I dont believe we should now. But this maybe a discussion we need to have at the TC level?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.